Don't register click when user moves away from Button before lifting finger#15
Merged
StevenDXC merged 2 commits intoStevenDXC:masterfrom Jan 6, 2018
Merged
Don't register click when user moves away from Button before lifting finger#15StevenDXC merged 2 commits intoStevenDXC:masterfrom
StevenDXC merged 2 commits intoStevenDXC:masterfrom
Conversation
Contributor
|
+1 this PR. @StevenDXC any chance of a code review and merge? |
Contributor
Author
|
@Lissy93 if you want to use it with the Changes of the PR you can use it as a dependency from my Repo using Jitpack.io: https://jitpack.io/#Seylox/dxloadingbutton |
|
Touch Event did not add ACTION_CANCEL. It is not work well if touch and then move public boolean onTouchEvent(MotionEvent event) { |
Owner
|
thanks, has merged @Seylox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.